Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MASTG-TEST-0231 for weak encryption modes on Android #3079

Merged
merged 12 commits into from
Nov 29, 2024
Merged

Add MASTG-TEST-0231 for weak encryption modes on Android #3079

merged 12 commits into from
Nov 29, 2024

Conversation

cpholguera
Copy link
Collaborator

No description provided.

@cpholguera cpholguera self-assigned this Nov 29, 2024
@cpholguera cpholguera requested a review from sushi2k November 29, 2024 10:07
@cpholguera cpholguera requested a review from serek8 November 29, 2024 14:13
@serek8
Copy link
Collaborator

serek8 commented Nov 29, 2024

@cpholguera Can we also include a set of weak Algorithm/Mode/Padding that a tester can check for? Right now there are only two examples, but I think there are more, right?

@cpholguera
Copy link
Collaborator Author

We could but we haven't been including those so explicitly until now so I'd leave it in the current form and we can revisit this and others later once we decide how to enter that kind of references.

@cpholguera cpholguera requested a review from Copilot November 29, 2024 16:20
Copilot
Copilot AI reviewed Nov 29, 2024
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 suggestion.

tests-beta/android/MASVS-CRYPTO/MASTG-TEST-0231.md Outdated Show resolved Hide resolved
@cpholguera cpholguera merged commit 1da6272 into master Nov 29, 2024
3 checks passed
@cpholguera cpholguera deleted the add-MASTG-TEST-0231 branch November 29, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot Copilot left review comments

@serek8 serek8 serek8 approved these changes

@sushi2k sushi2k Awaiting requested review from sushi2k

Assignees

@cpholguera cpholguera

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpholguera @serek8